Conversation
fb6b178 to
130d288
Compare
|
I am struggling with signing the commits given the multiple github accounts and ssh keys I have on this laptop. Will try again later. |
130d288 to
9d7c45e
Compare
|
Ready for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 92.94% 93.23% +0.28%
==========================================
Files 27 28 +1
Lines 751 783 +32
==========================================
+ Hits 698 730 +32
Misses 53 53 ☔ View full report in Codecov by Sentry. |
| pass_filenames: false | ||
| always_run: true | ||
| stages: [push] No newline at end of file | ||
| stages: [pre-push] No newline at end of file |
There was a problem hiding this comment.
pre-commit run --all-files triggers hook id 'ci-checks' uses deprecated stage names (push) which will be removed in a future version. run: 'pre-commit migrate-config' to automatically fix this.
running pre-commit migrate-config makes this modification to the pre-commit yaml
|
Hi @Anko59 , thank you very much for your contribution! |
Kamforka
left a comment
There was a problem hiding this comment.
I've left a couple of suggestions please check them out.
Altogether a really nice addition, thank you for that!
Co-authored-by: Kamforka <antalszabolcs01@gmail.com>
|
Thank you for your contribution @Anko59, great job! |
No description provided.