CI/TEST: Separate build, test and publish stages#5
Merged
TheChymera merged 5 commits intoTheChymera:autodata2from Aug 25, 2022
Merged
CI/TEST: Separate build, test and publish stages#5TheChymera merged 5 commits intoTheChymera:autodata2from
TheChymera merged 5 commits intoTheChymera:autodata2from
Conversation
TEST: Delay imports to avoid full installation
effigies
commented
Aug 25, 2022
TheChymera
requested changes
Aug 25, 2022
Owner
TheChymera
left a comment
There was a problem hiding this comment.
Thank you :) Most comments are just questions, but I really think (1) we'd be better off sticking with os.path unless there's something I'm missing; and (2) epoch is nicer, maybe you're more relaxed but I've certainly committed more than once a minute.
Run from anywhere, use meaningful commit/tag messages, do not push automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TheChymera For the sake of maintainable CI, I separated out the build, test and publish stages. Will make some comments to highlight the important bits.