Conversation
Member
Author
|
You'll probably notice the large file count when reviewing this PR. This is due to a multitude of reasons:
If you ever have trouble understanding a test, it's usually my fault and not yours. Please let me know if that's the case! You can also consult |
Member
Author
|
With that all out of the way, I've finished writing tests for all of our lints! This is ready for review, once #125 is merged. :) |
Closed
Member
Author
|
#125 is merged, so this is ready for review now! |
ad94cda to
4086aa3
Compare
4086aa3 to
9954aba
Compare
TimJentzsch
approved these changes
Oct 13, 2024
Collaborator
TimJentzsch
left a comment
There was a problem hiding this comment.
Really nice to have tests for these.
Left some minor comments, but feel free to merge once you think it's ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #31.
This is a continuation of #125 that actually adds UI tests for all of the current lints. It was split off to make #125 easier to review.
To test this, run:
cargo test -p bevy_lint --test uiTo bless changes, run:
cargo test -p bevy_lint --test ui -- --blessThere are a few additional options available if you replace
--blesswith--help, too.