Conversation
BD103
commented
Oct 4, 2024
TimJentzsch
approved these changes
Oct 6, 2024
Collaborator
TimJentzsch
left a comment
There was a problem hiding this comment.
Code looks good to me, although I don't really have any experience with the rustc internals :)
Member
Author
That's fine! I don't expect you to know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
bevy_lint_driverbinary behave a bit more likeclippy-driver, which means it also behaves a bit more likerustc. Some changes include:RUSTC_LOGvariable to configure logging levels and scope. (It usestracinginternally!)rustcdrivers: specifically usingcatch_with_exit_code().I'm currently debugging an issue with this whereserde_derivefails to compile (I believe it's therustc_driver::args::raw_args()call), so I'll update this when I fix it. :)