Skip to content

Conversation

@XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Mar 7, 2023

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

Fixes #2863

Add new function _get_braces_for_deque to respect maxlen for collections.deque.
Add tests for pretty_repr with non-empty and empty deque.

@XuehaiPan XuehaiPan changed the title fix: fix get braces for deque fix: fix pretty_repr for deque Mar 7, 2023
@willmcgugan willmcgugan enabled auto-merge July 1, 2024 10:52
@willmcgugan willmcgugan disabled auto-merge July 1, 2024 10:52
@willmcgugan willmcgugan merged commit 9e3933f into Textualize:master Jul 1, 2024
@XuehaiPan XuehaiPan deleted the fix-deque-maxlen branch March 12, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] rich.pretty is not showing maxlen for collections.deque

2 participants