Function Name in Logger by Default #1113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like so `app.py:supervised_api:74`
Add func name in between file name and line number
Author
|
The edit is literally one line, and works by default, so I did not want to add tests/documentation to the code. |
willmcgugan
reviewed
Mar 17, 2021
| level=level, | ||
| path=path, | ||
| line_no=record.lineno, | ||
| line_no=f'{record.funcName}:{record.lineno}', |
Member
There was a problem hiding this comment.
This may break typing since line_no is an integer.
Author
There was a problem hiding this comment.
Do you suggest I add a new keyword argument at RichHandler? Something like show_function_name
Member
|
I wouldn't want to do this by default, mainly for space issues--a long function name could leave little space for the rest of the log text. It would be a nice addition, but it would have to be optional and off by default. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function name to logging, and works by default
Type of changes
Checklist
Description
Really wanted to have function name as part of file name and line number