Add parameter conditions to function trigger#219
Merged
Conversation
Replace the untyped Parameter field on FunctionValue with a typed Parameters []ParameterCondValue slice, mirroring the EventEmitted pattern. Wire parameters through ToRequest() and Validate(), and add the Parameters field to the generated FunctionFilter struct. Add tests covering valid configurations (name, signature, parameters, not flag) and invalid ones (signature+name, signature+parameters, missing name/signature, parameter without name).
Add StrValue type with custom JSON/YAML unmarshalers to support both
plain string shorthand and expanded {exact, not} format for parameter
string comparisons.
g4zyn
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parametersarray to thefunctiontrigger filter, replacing the old unsupportedparametermap field. Supportsstring(exact match) andint(eq/gt/gte/lt/lte)comparisons against decoded function arguments.
TODOand"Parameter not yet supported"error block — parameters are now fully wiredthrough
Validate()andToRequest().signature(enforced via the existingMsgSignatureAndParameterForbiddenconstraint); they requirename-based matching only.FunctionFilterto include aParameters []ParameterConditionfield.
Example YAML
Test plan
ToRequest()
ToRequest()
together
assertions for all filter types