Make spawn-rpc "return" url instead of logging/printing it#164
Merged
Make spawn-rpc "return" url instead of logging/printing it#164
spawn-rpc "return" url instead of logging/printing it#164Conversation
Current implementation just prints the URL instead of returning it, so the current command can't be used in bash scripts.
Contributor
Author
|
Running won't print anything, but But running will print the URL, but it won't be written to the So I just changed this command to return the value using |
daleksov
approved these changes
Oct 26, 2023
Contributor
daleksov
left a comment
There was a problem hiding this comment.
Additional flag is way more safe. So I'm OK with this approach, since we are not going to affect any of the existing integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation just prints the URL instead of returning it, so the current command can't be used in bash scripts.