Feature - Playwright Support for Trace Zip Mapping#296
Merged
auvipy merged 9 commits intoTeemu:mainfrom Aug 16, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds Playwright trace file support to pytest-sugar, enabling automatic detection and display of trace.zip files for failed tests to improve debugging experience.
- Adds two new CLI options for configuring trace file detection behavior
- Implements trace file discovery logic that maps test failures to their corresponding trace.zip files
- Displays trace file paths and Playwright view commands in test failure output
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pytest_sugar.py | Adds CLI options and trace detection logic with display formatting for failed tests |
| RELEASE.md | Documents the new feature and CLI options |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
justinmayer
reviewed
Aug 11, 2025
Collaborator
justinmayer
left a comment
There was a problem hiding this comment.
Hi @kiebak3r. Many thanks for your pull request submission. I made a couple of suggested changes. Would you please take a look at my comments and let me know what you think?
justinmayer
reviewed
Aug 16, 2025
Collaborator
justinmayer
left a comment
There was a problem hiding this comment.
Other than a very minor capitalization consistency suggestion, I have no additional notes — this looks good to me 👍
README.md
Outdated
|
|
||
|
|
||
| Specify the directory where Playwright trace files are stored. | ||
| Defaults to playwright default: "test-results" |
Collaborator
There was a problem hiding this comment.
Capitalize Playwright here for consistency?
auvipy
approved these changes
Aug 16, 2025
auvipy
reviewed
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional CLI args to map created trace zip files to test failures via playwright --tracing flag
Helps playwright users associate and debug zips faster