Skip to content

Maint/migrate to vs2019#8

Merged
PieboyMcGillicuddy merged 3 commits intomainfrom
maint/migrate_to_vs2019
Jun 16, 2021
Merged

Maint/migrate to vs2019#8
PieboyMcGillicuddy merged 3 commits intomainfrom
maint/migrate_to_vs2019

Conversation

@PieboyMcGillicuddy
Copy link
Copy Markdown

@PieboyMcGillicuddy PieboyMcGillicuddy commented Jun 15, 2021

  1. Created new set of projects and upgraded them
  2. Turned off min rebuild flag for debug configs, because it was conflicting with cpplatest.
  3. Rev

Note: no SourceLink stuff. Symbols we off for the build, so I'm going to avoid introducing the first NuGet package dependencies for these projects.

@PieboyMcGillicuddy PieboyMcGillicuddy force-pushed the maint/migrate_to_vs2019 branch from 12f1b29 to 26401a9 Compare June 15, 2021 21:33
Copy link
Copy Markdown

@adammarks adammarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Zlib.autopkg Outdated
- Updated toolset to v142 for Visual Studio 2019
";
copyright: @"Copyright (c) 2018.";
tags: { zlib, CoApp, compression, vs2017, native };
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at when we previously made updates to visual studio , Should also add vs2019 to the tags

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks.

@PieboyMcGillicuddy PieboyMcGillicuddy force-pushed the maint/migrate_to_vs2019 branch from 26401a9 to 3eb25e1 Compare June 16, 2021 13:18
@PieboyMcGillicuddy PieboyMcGillicuddy merged commit 77cd478 into main Jun 16, 2021
@PieboyMcGillicuddy PieboyMcGillicuddy deleted the maint/migrate_to_vs2019 branch June 16, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants