Include minizip's headers in the nuget pkg#7
Conversation
Zlib.autopkg
Outdated
| { | ||
| nestedInclude: { #destination=${d_include}Zlib; *.h }; | ||
| nested2Include: { #destination=${d_include}Zlib; "*.h" }; | ||
| nested1Include: { #destination=${d_include}contrib\minizip; "*.h" }; |
There was a problem hiding this comment.
This is not correct. It means that all headers should go under contrib\minizip
(BTW you can open up the nuget package with 7zip, no need to install the package)
There was a problem hiding this comment.
I think it should be something like (untested):
{ #destination=${d_include}Zlib\contrib\minizip; "contrib\minizip\*.h" };
^
We want the contrib to go under Zlib, so that the consumer does:
#include <ZLib/contrib/minizip/ioapi.h>
instead of
#include <contrib/minizip/ioapi.h> <<<< not Zlib specific, it does not look good.
There was a problem hiding this comment.
🤦 I thought I saw the correct ones there before - I'm sorry waste your time with this one. Re 7zip, yeah, I've got *.nupkg associated with 7zip. Fixed nupkg is here. Corrected autopkg has been force pushed.
There was a problem hiding this comment.
Thanks for the update and np on me trying out that version. Will test it on Monday!
Was it built on your machine?
One thing that I still have to look into is that pesky warning:
warning LNK4098: defaultlib 'libcmt.lib' conflicts with use of other libs; use /NODEFAULTLIB:library
Not exactly sure what project is "at fault" and how I can solve this but I will look on Monday
There was a problem hiding this comment.
Yes, built on my machine. Time permitting, I'll try your branch and this nupkg on my branch today, and see if I can learn anything about that warning.
David-Defoort
left a comment
There was a problem hiding this comment.
The resulting nuget package does not have the files that we need ioapi.h and unzip.h
69679e3 to
15b51e2
Compare
| { | ||
| nestedInclude: { #destination=${d_include}Zlib; *.h }; | ||
| nested2Include: { #destination=${d_include}Zlib; "*.h" }; | ||
| nested1Include: { #destination=${d_include}Zlib\contrib\minizip; "contrib\minizip\*.h" }; |
There was a problem hiding this comment.
Looks good. Will test on Monday :)
This is necessary so the minizip headers will be found by the compiler and successfully compiled in SnagitWin when using the zlib NuGet pkg.
a45d440 to
8658568
Compare
8658568 to
98d3044
Compare
|
It all looks good. Used the nuget package that @BillHoag built locally and confirm this would work just fine in SnagitWin 👍 |
Uh oh!
There was an error while loading. Please reload this page.