Skip to content

fix(packaging): ship plugin.yaml via package-data + MANIFEST.in (closes #76)#77

Merged
PowerCreek merged 1 commit into
mainfrom
issue-76-packaging-yaml
May 24, 2026
Merged

fix(packaging): ship plugin.yaml via package-data + MANIFEST.in (closes #76)#77
PowerCreek merged 1 commit into
mainfrom
issue-76-packaging-yaml

Conversation

@PowerCreek

Copy link
Copy Markdown

Closes #76. Critical packaging bug: pip-installed hermes-agent wheel from main shipped ZERO plugin.yaml files → loader silently skipped every devagentic-* plugin → G1/G2/G3/G4 all installed-but-non-functional in the duplex container after pip-reinstall.

Root cause

pyproject.toml had [tool.setuptools.package-data] mapping plugins = […] but the patterns only covered */dashboard/manifest.json + */dashboard/dist/*. No plugin.yaml pattern anywhere. [tool.setuptools.packages.find] picks up .py files only; non-.py files require explicit package-data or include-package-data = true + MANIFEST.in.

So find_packages() ran fine (33 plugin packages found), .py files were shipped, but the per-plugin plugin.yaml was silently dropped by the build backend → loader's __init__.py + plugin.yaml requirement failed silently.

Fix

Both layers (belt-and-suspenders for sdist + wheel build backends):

  1. pyproject.toml — expand plugins = [...] package-data globs to cover plugin.yaml + README + skills + JSON + assets at all depths via ** patterns:
    plugins = [
      "**/plugin.yaml",
      "**/plugin.yml",
      "**/*.md",
      "**/*.txt",
      "**/*.json",
      "**/dashboard/dist/*",
      "**/dashboard/dist/**/*",
      "**/skills/**/*",
      "**/*.js",
      "**/*.css",
      "**/*.png",
      "**/*.service",
    ]
  2. MANIFEST.inrecursive-include plugins *.yaml *.yml *.md *.txt *.json + similar for skills/ + dashboard/.

End-to-end verification

Built the wheel + inspected zip contents:

total entries: 1477
yaml/yml entries: 72          (was 0 pre-fix)
plugin entries: 242
plugin.yaml files in wheel:
  plugins/devagentic-vertical-preamble/plugin.yaml  ← G1
  plugins/devagentic-mutations/plugin.yaml          ← G2
  plugins/hermes-github/plugin.yaml                 ← G3
  plugins/devagentic-lane-h/plugin.yaml             ← G4
  plugins/devagentic-canvas/plugin.yaml
  plugins/devagentic-docs/plugin.yaml
  + 60 others (browser/, image_gen/, memory/, model-providers/, …)

Test plan

  • 9 packaging-contract tests in tests/test_packaging_plugins.py:
    • pyproject.toml includes **/plugin.yaml (or compatible) glob
    • pyproject.toml includes **/*.md glob
    • pyproject.toml includes skills/ glob
    • MANIFEST.in has recursive-include plugins *.yaml
    • MANIFEST.in has recursive-include plugins *.md
    • At least 5 plugin.yaml files exist in-tree (catches degenerate config)
    • G1 plugin.yaml exists at the expected path
    • G2/G3/G4 plugin.yaml files exist at expected paths
    • All in-tree plugin.yaml files are covered by the configured globs (depth analysis)
  • End-to-end pip wheel build inspected: 72 yaml entries present (was 0 pre-fix).
  • Test does NOT actually build the wheel in CI (slow); validates the CONTRACT — packaging config + in-tree files. End-to-end build confirmation done manually + documented in PR body.

Combined with NousResearch#221

Both required for the fusion stack to function on a pip-reinstall + service restart. Either alone leaves a silent failure.

Deploy

Operator-side container rebuild from main (G6/#66 cycle). After this lands + container redeploys:

  • find /home/duplex/.local/lib/python3.11/site-packages/plugins -name plugin.yaml returns ~25+ files
  • hermes boot shows the post-G1-G4 tool count (33+ MCP tools, not 16 from the pre-G1-G4 v0.14.0 binary)
  • Polynomial-explorer worker sees the preamble + tools and makes actual progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRITICAL: pip-installed wheel ships zero plugin.yaml files — every devagentic-* plugin silently skipped on install

1 participant