memory: holographic health_check + collapse doctor branches (closes #42)#52
Merged
Merged
Conversation
…s 2h + 3) Closes #42. Final two steps of the RFC migration. Step 2h — holographic health_check: Holographic is local-only (SQLite); no remote service. But a read-only HERMES_HOME (RO mount, wrong perms) would still break it at runtime. Override verifies db_path's parent directory is writable. (True, "") — parent mkdir + W_OK pass. (False, "unreachable: <msg>") — mkdir failed or W_OK denied. (False, "config_error: <msg>") — get_hermes_home raised. Step 3 — doctor branch collapse: Every shipped provider now implements health_check() with the RFC #42 reason-prefix taxonomy. The provider-specific Honcho + Mem0 elif blocks (~120 lines combined) are gone. The unified dispatch is one ~80-line block in doctor.py keyed on the prefix: healthy → check_ok("<name> reachable") no_api_key / no_credentials → _fail_and_issue (setup hint) no_url / no_endpoint → _fail_and_issue (URL hint) no_config → check_warn (run setup) disabled → check_info sdk_missing → _fail_and_issue (plugin docs) auth: → _fail_and_issue (rotate key) not_found: → _fail_and_issue (verify base URL) http: → check_warn (unexpected status) unreachable: → check_warn (transient hint) config_error: → check_warn (config raised) health_check_raised: → check_warn (provider bug; RFC #42 says health_check MUST NOT raise, so this is a contract violation worth flagging) other → check_warn (unknown verbatim) Doctor's Memory Provider section is now ~80 lines instead of ~200, and adding the 9th provider requires zero doctor changes. Migration table (8 providers total): mem0 — PR #44 GET /v1/memory profile honcho — PR #45 get_honcho_client handshake byterover — PR #46 brv status (CLI + login) supermemory — PR #48 client.profile probe openviking — PR #49 /health endpoint probe retaindb — PR #50 /v1/memory/profile GET hindsight — PR #51 mode-dependent (local import / cloud /version) holographic — this PR db_path parent writability Tests: - 6 new tests for holographic health_check - Updated 3 doctor tests to assert the new unified dispatch (auth → _fail_and_issue; unreachable → check_warn; healthy → "<name> reachable") instead of the now-removed elif-block output strings. - 228 health_check + doctor tests pass total. The #42 RFC is now fully implemented across all shipped memory providers. Closing the issue with this PR.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #42. Final two steps of the RFC migration.
Step 2h — holographic health_check
Holographic is local-only (SQLite); no remote service. But a read-only HERMES_HOME (RO mount, wrong perms) would still break it at runtime. Override verifies
db_path's parent directory is writable.(True, "")mkdir+W_OKpass(False, "unreachable: <msg>")mkdirfailed orW_OKdenied(False, "config_error: <msg>")get_hermes_homeraisedStep 3 — doctor branch collapse
Every shipped provider now implements
health_check()with the RFC #42 reason-prefix taxonomy. The provider-specific Honcho + Mem0 elif blocks (~120 lines combined) are gone. The unified dispatch is one ~80-line block indoctor.pykeyed on the prefix:check_ok("<name> reachable")no_api_key/no_credentials_fail_and_issue(setup hint)no_url/no_endpoint_fail_and_issue(URL hint)no_configcheck_warn(run setup)disabledcheck_infosdk_missing_fail_and_issue(plugin docs)auth:_fail_and_issue(rotate key)not_found:_fail_and_issue(verify base URL)http:check_warn(unexpected status)unreachable:check_warn(transient hint)config_error:check_warnhealth_check_raised:check_warn(contract violation per RFC #42 — flag it)check_warn(unknown verbatim)Doctor's Memory Provider section is now ~80 lines instead of ~200, and adding the 9th provider requires zero doctor changes.
Migration table (8 providers)
MemoryClient.get_all(user_id, limit=1)get_honcho_client(cfg)handshakebrv status(CLI + login)client.profile(container_tag=...)GET <endpoint>/healthGET /v1/memory/profile/<probe>GET /version)Test plan
auth:→_fail_and_issue;unreachable:→check_warnwith "credentials may still be valid" hint; healthy →<name> reachable) instead of the now-removed elif-block strings.pytest tests/plugins/memory/ tests/honcho_plugin/test_health_check.py tests/agent/test_memory_provider.py tests/hermes_cli/test_doctor.py→ 228 passed. Pre-existingtest_get_client_passes_idle_timeout_to_hindsight_embeddedfailure is an env-specific PEP-668 issue, not a regression (verified onmain).The #42 RFC is fully implemented across all shipped memory providers. Closing the issue with this PR.
Filed by hermes-maintainer (PowerCreek).