doctor: probe gateway runtime state (state / uptime / per-platform)#31
Merged
Conversation
Completing the gateway/cron/batch_runner audit sweep: - cron probe shipped in #27 (gateway PID + recent failures) - batch_runner failure stats shipped in #29 (per-prompt failures) - this PR: gateway runtime state itself `hermes doctor` previously only checked whether systemd linger was enabled. The gateway already maintains a rich runtime status file at gateway/status.py:read_runtime_status() — keyed by gateway_state ∈ {starting, running, draining, stopped, startup_failed, degraded}, with exit_reason, start_time, active_agents, and per-platform health. Doctor didn't read it. Add `_check_gateway_runtime()` covering: - `running` → check_ok with PID + uptime + active_agents - `degraded` → check_warn pointing at platform errors below - `startup_failed` → check_fail with exit_reason + updated_at - `stopped` → check_info (intentional stop, not an alert) - `starting`/`draining` → check_info (transient) - PID present but no state → check_warn (old build, stale status) Plus per-platform health: connected platforms listed as a single check_info line; any fatal platform becomes check_fail with error_message; any paused/retrying platform becomes check_warn. Inert when the runtime status file is absent (gateway never started — byte-stable default). Closes #30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #30. Completing the gateway/cron/batch_runner audit sweep:
hermes doctorpreviously only checked systemd linger. The gateway already maintains a rich runtime status file atgateway/status.py:read_runtime_status()— keyed bygateway_state∈ {starting, running, draining, stopped, startup_failed, degraded}, withexit_reason,start_time,active_agents, and per-platform health. Doctor didn't read it.What's now surfaced
runningdegradedstartup_failedstoppedstarting/drainingPer-platform health: connected platforms listed in one info row; any
fatalplatform becomescheck_failwitherror_message; anypausedorretryingplatform becomescheck_warn.Inert when the runtime status file is absent (gateway never started — preserves byte-stable default).
Example output
Healthy:
Broken:
Test plan
tests/hermes_cli/test_doctor_gateway_runtime.py:_format_uptimecovers seconds / minutes / hourspytest tests/hermes_cli/test_doctor*.py→ 88 passed (76 existing + 12 new)Filed by hermes-maintainer (PowerCreek).