Skip to content

Add analysis to show list of growing apps #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VishalNehra merged 30 commits into from
Dec 31, 2023
Merged

Add analysis to show list of growing apps #141

VishalNehra merged 30 commits into from
Dec 31, 2023

Conversation

@seelchen
Copy link
Contributor

@seelchen seelchen commented Dec 9, 2023 •
edited
Loading

Description

This adds an analysis to show by how much each installed app has grown within a configurable amount of time.
A background service is used to query the size of each app every day and store it in the database.

Issue tracker

Fixes #139

@seelchen
start adding database table and classes for app storage stats
44c703b
@seelchen
make package_id a foreign key in create table query and define onCh…
93d1480 
…ange policy
@seelchen
change index to include timestamp
099918b
@seelchen
rename to AppStorageStatsand add inserts for single `AppStorageStat…
a5f3f73 
…s` in dao
@seelchen
change to use intermediate data class instead of embedded objects to …
14e7233 
…combine `AppStorageStats` and `InstalledApps`
@seelchen
add new daos to AppDatabase
acd36fe
@seelchen
add new function where the size of the MediaFileInfo can be specified
c39a1b7
@seelchen
fix some issues with the new database table
c8f11fa 
Add the `AppStorageStats` entity to the database, fix the index in the
annotation of `AppStorageStats` and fix `AppStorageStatsDao` to get
`InstalledAppsDao` from database
@seelchen
add a priority queue with fixed size
397b096
@seelchen
change to use new FixedSizePrioityQueue
0d915bc
@seelchen
change findOldestWithinPeriod to return Nullable object since there…
4899273 
… might be no matching entry
@seelchen
fix migration to use correct datatypes in sql statement and add index…
9ba8ee0 
… for foreign key
@seelchen
add setting for the number of days for the size diff
da9232d
@seelchen seelchen force-pushed the feature/app-size-diff branch from 4ce6982 to da9232d Compare December 17, 2023 18:51
@seelchen
add androidx.work dependency
09b3ec7
@seelchen
update androidx.room version for compatibility with androidx.work
cba89c8
@seelchen
fix foreign key constraint issue
26b7276 
The InstalledApps were inserted with OnConflictStrategy.REPLACE which
would delete the entry and replace it. However, this would also delete
the associated AppStorageStats entries so now insert ignores conflicts
and there is a new `updateOrInsert` function which updates the entry or
inserts it if it is not yet in the table
@seelchen
register a Worker to store the size of every app once a day
9e7cdd2
@seelchen
change MediaFileInfo to store a size diff in ApkMetaData
9b03836
@seelchen
implement calcuation of size diff of apps
5360618
@seelchen
add analysis preview of growing apps in AnalyseFragment
7e896cf
@seelchen
add analysis review of growing apps
f100d4a
@seelchen
add new database schema
332d9ef
@seelchen
add comments
8fd70d7
@seelchen
add dependencies for room database tests
263c608
@seelchen
add test for database migrations
a4178b4
@seelchen
add tests for new daos
6b5f452
@seelchen seelchen marked this pull request as ready for review December 20, 2023 18:13
@seelchen
Copy link
Contributor Author

seelchen commented Dec 20, 2023

This is ready for review!
I tried to add tests for the worker, but I couldn't find a way to mock static methods with mockito. I also couldn't use mockk because its target JVM version is different to the one of the project. If you have any other mocking library suggestions, I can try to write test with them, but as far as I can tell from my manual testing, the worker works fine.

VishalNehra
VishalNehra requested changes Dec 21, 2023
View reviewed changes
@seelchen seelchen requested a review from VishalNehra December 22, 2023 16:25
@seelchen
Copy link
Contributor Author

seelchen commented Dec 22, 2023

After I deleted the database and reinstalled the debug app to test the new commit, I saw that the analysis showed that all apps grew a lot.
I think that is because when the PeriodicWorkRequest is executed for the first time, I did not grant the UsageStats permission yet. Therefore, the findApplicationInfoSizeFallback method is used to get an approximation of the app size. However, when I grant the UsageStats permission, the exact app size can be determined and makes it seem like the apps all grew a lot.
I wanted to ask if I should add a check in the PeriodicWorkRequest if the UsageStats permission was granted for versions >= Build.VERSION_CODES.O or if the current behavior is fine?

@VishalNehra
Copy link
Member

VishalNehra commented Dec 22, 2023

I was wondering the same why it's showing such huge difference. Yes, you should the change to add a check. Only add entries when we have permissions

@seelchen
Copy link
Contributor Author

seelchen commented Dec 29, 2023

I was wondering the same why it's showing such huge difference. Yes, you should the change to add a check. Only add entries when we have permissions

Fixed in the latest two commits. To see the change, you need to delete all old values of in the database.

@VishalNehra
Copy link
Member

VishalNehra commented Dec 31, 2023

Amazing work! Looks good :)

@VishalNehra VishalNehra merged commit f931843 into TeamAmaze:main Dec 31, 2023
@seelchen seelchen mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VishalNehra VishalNehra VishalNehra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analysis to show list of apps that are growing in size

2 participants

@seelchen @VishalNehra