Emit dummy impls on error#248
Merged
TeXitoi merged 3 commits intoTeXitoi:masterfrom Sep 2, 2019
CreepySkeleton:dummy_impl
Merged
Emit dummy impls on error#248TeXitoi merged 3 commits intoTeXitoi:masterfrom CreepySkeleton:dummy_impl
TeXitoi merged 3 commits intoTeXitoi:masterfrom
CreepySkeleton:dummy_impl
Conversation
TeXitoi
approved these changes
Sep 2, 2019
Owner
TeXitoi
left a comment
There was a problem hiding this comment.
Maybe something like "Remove useless error message when a meaningful error is generated"?
Collaborator
Author
|
Changelog updated + rebased. Ready to go in |
TeXitoi
approved these changes
Sep 2, 2019
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #240
Also I moved
tests/uitotests/ui-common.I'm not sure what to write in changelog, could use your guidance here