fix(angular-table): View is not updated anymore when flexRenderDirective is instantiated the first time with an empty value#5626
Merged
KevinVandy merged 4 commits intoTanStack:mainfrom Jun 29, 2024
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f03fd09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
KevinVandy
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using Angular table adapter in our application, we discovered an issue with FlexRenderDirective that prevents the content from being shown if the cell renders a
null | undefinedvalue the first time.Use case:
datawith the same cell valuated (e.g. after the user does an update operation)The issue is related to the current rendering mechanism, which is invoked inside the
ngOnInithook (one-time, only after Angular initialized all the inputs).I moved the logic inside ngOnChanges, so that everything is invoked whenever the inputs change. I had to update some test according to this fix, so I moved the first two check about null | undefined in order to be sure that the content is reactive and always rendered (except for null | undefined)
Since we are using ngOnChanges, we don't need anymore to call the markForCheck while rendering a Component or TemplateRef inside the ngDoCheck