Skip to content

Run rename-unsafe-lifecycles on v6 branch#1461

Closed
nbar1 wants to merge 1 commit into
TanStack:v6from
nbar1:v6
Closed

Run rename-unsafe-lifecycles on v6 branch#1461
nbar1 wants to merge 1 commit into
TanStack:v6from
nbar1:v6

Conversation

@nbar1

@nbar1 nbar1 commented Aug 19, 2019

Copy link
Copy Markdown

No description provided.

@tannerlinsley

Copy link
Copy Markdown
Member

I'm not sure I can do this without doing a major semver release. This would break a lot of people as a minor or patch release

@nbar1

nbar1 commented Aug 19, 2019

Copy link
Copy Markdown
Author

No worries, as v6 won't be receiving any large changes in anticipation of v7, I will import it from my repo until we upgrade.

@tannerlinsley

Copy link
Copy Markdown
Member

Sounds good. I think that's the best solution for now. Thanks!

@fttriquet

Copy link
Copy Markdown

Are you going to do a 6.11 version with this ? If so when is it planned ?

Thanks

@benflodge

Copy link
Copy Markdown

This fix has broken compatibility with Preact, as they are not supporting the UNSAFE* methods preactjs/preact#1047. I have fixed my react-table version to 6.10.0 as this version still works with Preact.

@benflodge

Copy link
Copy Markdown

There is a now a bug for Preact tracking the broken compatibility issue preactjs/preact#1941.

@vis2992

vis2992 commented Oct 25, 2019

Copy link
Copy Markdown

Seems like the preact issue is resolved now, could this PR be opened up again and released as a new major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants