Conversation
* fix: better react HMR * layout and fixes * fix * stabilize test * stabilize test
* feat: transformAssets replaces transformAssetUrls * fix * fix
--------- Co-authored-by: Birk Skyum <birk.skyum@pm.me>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
|
View your CI Pipeline Execution ↗ for commit 3339dbd
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
Merging this PR will degrade performance by 9.69%
Performance Changes
Comparing Footnotes |
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We fixed two type/lint failures introduced during the main→solidv2 merge by aligning code with the solid-js v2 API. The unused replaceEqualDeep import was removed from headContentUtils.tsx, and benchmarks/client-nav/solid/app.tsx was corrected to use @solidjs/web for render, the two-argument form of createRenderEffect, and accessor unwrapping for For item callbacks.
Tip
✅ We verified this fix by re-running @tanstack/solid-router:test:eslint, @benchmarks/client-nav:test:types.
Suggested Fix changes
diff --git a/benchmarks/client-nav/solid/app.tsx b/benchmarks/client-nav/solid/app.tsx
index ef90130f5e..46eb01d927 100644
--- a/benchmarks/client-nav/solid/app.tsx
+++ b/benchmarks/client-nav/solid/app.tsx
@@ -1,5 +1,5 @@
import { For, createRenderEffect } from 'solid-js'
-import { render } from 'solid-js/web'
+import { render } from '@solidjs/web'
import {
Link,
Outlet,
@@ -37,9 +37,10 @@ const routeSelectors = Array.from({ length: 6 }, (_, index) => index)
const linkGroups = Array.from({ length: 4 }, (_, index) => index)
function PerfValue(props: { value: () => number }) {
- createRenderEffect(() => {
- void props.value()
- })
+ createRenderEffect(
+ () => props.value(),
+ () => {},
+ )
return null
}
@@ -67,13 +68,14 @@ function LinkPanel() {
<>
<For each={linkGroups}>
{(groupIndex) => {
- const itemsId = groupIndex === 0 ? 1 : groupIndex + 2
- const ctxId = groupIndex + 1
+ const gi = groupIndex()
+ const itemsId = gi === 0 ? 1 : gi + 2
+ const ctxId = gi + 1
return (
<div>
<Link
- data-testid={groupIndex === 0 ? 'go-items-1' : undefined}
+ data-testid={gi === 0 ? 'go-items-1' : undefined}
to="/items/$id"
params={{ id: itemsId }}
replace
@@ -84,27 +86,27 @@ function LinkPanel() {
{`Items ${itemsId}`}
</Link>
<Link
- data-testid={groupIndex === 0 ? 'go-items-2' : undefined}
+ data-testid={gi === 0 ? 'go-items-2' : undefined}
to="/items/$id"
params={{ id: 2 }}
replace
activeOptions={{ includeSearch: false }}
>
- {`Items 2 alt ${groupIndex}`}
+ {`Items 2 alt ${gi}`}
</Link>
<Link
- data-testid={groupIndex === 0 ? 'go-search' : undefined}
+ data-testid={gi === 0 ? 'go-search' : undefined}
to="/search"
- search={{ page: 1, filter: 'all', junk: `group-${groupIndex}` }}
+ search={{ page: 1, filter: 'all', junk: `group-${gi}` }}
replace
activeOptions={{ includeSearch: true }}
activeProps={{ class: 'active-link' }}
inactiveProps={{ class: 'inactive-link' }}
>
- {`Search ${groupIndex}`}
+ {`Search ${gi}`}
</Link>
<Link
- data-testid={groupIndex === 0 ? 'go-ctx' : undefined}
+ data-testid={gi === 0 ? 'go-ctx' : undefined}
to="/ctx/$id"
params={{ id: ctxId }}
search={true}
@@ -117,16 +119,16 @@ function LinkPanel() {
from={searchRoute.fullPath}
to="/search"
search={(prev: { page: number; filter: string }) => ({
- page: prev.page + groupIndex + 1,
+ page: prev.page + gi + 1,
filter: prev.filter,
- junk: `updater-${groupIndex}`,
+ junk: `updater-${gi}`,
})}
activeOptions={{ includeSearch: true }}
>
{({ isActive }) =>
isActive
- ? `Search updater active ${groupIndex}`
- : `Search updater inactive ${groupIndex}`
+ ? `Search updater active ${gi}`
+ : `Search updater inactive ${gi}`
}
</Link>
</div>
diff --git a/packages/solid-router/src/headContentUtils.tsx b/packages/solid-router/src/headContentUtils.tsx
index c1ed5e271c..30ae9540b9 100644
--- a/packages/solid-router/src/headContentUtils.tsx
+++ b/packages/solid-router/src/headContentUtils.tsx
@@ -2,7 +2,6 @@ import * as Solid from 'solid-js'
import {
escapeHtml,
getAssetCrossOrigin,
- replaceEqualDeep,
resolveManifestAssetLink,
} from '@tanstack/router-core'
import { useRouter } from './useRouter'
Or Apply changes locally with:
npx nx-cloud apply-locally VGZL-aCXz
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
No description provided.