test(react-query/useMutation): remove '@testing-library/jest-dom/vitest' import by sukvvon · Pull Request #9569 · TanStack/query

sukvvon · 2025-08-15T11:44:08Z

Summary by CodeRabbit

Tests
- Updated test setup by removing implicit DOM matcher augmentation within a mutation-related test suite.
- Aligns tests to use centralized configuration for matchers and environment setup.
- No changes to application behavior or public APIs; runtime functionality remains unaffected.
- Ensures clearer test dependencies and reduces hidden coupling to test utilities.

…st' import

…library-jest-dom-vitest-import

nx-cloud · 2025-08-15T11:44:50Z

View your CI Pipeline Execution ↗ for commit 0a6dbd0

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 6s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	28s	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-20 03:53:57 UTC

pkg-pr-new · 2025-08-15T11:46:12Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9569

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9569

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9569

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9569

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9569

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9569

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9569

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9569

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9569

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9569

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9569

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9569

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9569

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9569

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9569

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9569

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9569

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9569

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9569

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9569

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9569

commit: 0a6dbd0

codecov · 2025-08-15T11:47:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.38%. Comparing base (7c464e3) to head (0a6dbd0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9569       +/-   ##
===========================================
+ Coverage   45.15%   84.38%   +39.23%     
===========================================
  Files         208       26      -182     
  Lines        8323      365     -7958     
  Branches     1885      107     -1778     
===========================================
- Hits         3758      308     -3450     
+ Misses       4118       48     -4070     
+ Partials      447        9      -438

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`95.95% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…library-jest-dom-vitest-import

coderabbitai · 2025-08-20T03:50:58Z

Caution

Review failed

The pull request is closed.

Walkthrough

Removed the import of '@testing-library/jest-dom/vitest' from a React Query mutation test, leaving all test logic unchanged.

Changes

Cohort / File(s)	Summary
Test setup import removal `packages/react-query/src/__tests__/useMutation.test.tsx`	Deleted top-level import of '@testing-library/jest-dom/vitest'; no other test code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled a line, a tiny bite—
A matcher’s whisper left the night.
Tests still hop, their paths the same,
Just lighter now in setup’s frame.
Thump-thump! I prune with gentle cheer,
Clean burrows make results more clear. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7c464e3 and 0a6dbd0.

📒 Files selected for processing (1)

packages/react-query/src/__tests__/useMutation.test.tsx (0 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

test(react-query/useMutation): remove '@testing-library/jest-dom/vite…

e9d92c4

…st' import

github-actions bot added the package: react-query label Aug 15, 2025

Merge branch 'main' into test/react-query-useMutation-remove-testing-…

7de815d

…library-jest-dom-vitest-import

manudeli approved these changes Aug 20, 2025

View reviewed changes

Merge branch 'main' into test/react-query-useMutation-remove-testing-…

0a6dbd0

…library-jest-dom-vitest-import

manudeli merged commit a1b1279 into TanStack:main Aug 20, 2025
7 of 8 checks passed

sukvvon deleted the test/react-query-useMutation-remove-testing-library-jest-dom-vitest-import branch August 20, 2025 04:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(react-query/useMutation): remove '@testing-library/jest-dom/vitest' import#9569

test(react-query/useMutation): remove '@testing-library/jest-dom/vitest' import#9569
manudeli merged 3 commits intoTanStack:mainfrom
sukvvon:test/react-query-useMutation-remove-testing-library-jest-dom-vitest-import

sukvvon commented Aug 15, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

nx-cloud bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 20, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sukvvon commented Aug 15, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

nx-cloud bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Aug 15, 2025 •

edited by coderabbitai bot

Loading

nx-cloud bot commented Aug 15, 2025 •

edited

Loading

pkg-pr-new bot commented Aug 15, 2025 •

edited

Loading

codecov bot commented Aug 15, 2025 •

edited

Loading

coderabbitai bot commented Aug 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)