tests(svelte-query): Reorganise for multiple components per test#7654
Merged
lachlancollins merged 3 commits intomainfrom Jul 1, 2024
Merged
tests(svelte-query): Reorganise for multiple components per test#7654lachlancollins merged 3 commits intomainfrom
lachlancollins merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6d6a378. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6d6a378:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7654 +/- ##
===========================================
+ Coverage 44.08% 80.86% +36.77%
===========================================
Files 185 18 -167
Lines 7054 162 -6892
Branches 1553 32 -1521
===========================================
- Hits 3110 131 -2979
+ Misses 3578 27 -3551
+ Partials 366 4 -362
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to the react-query tests, it's not quite as straightforward to write svelte-query tests, as they can't be included as functions within the test definition, but need to be separate file components.
This PR refactors each source file's tests to be a folder, making it easier to add multiple components per test (rather than trying to conform a single component to poorly suit multiple tests).
As a demo, I've added new tests for
useIsFetchingandQueryClientProvider, and an additional test forcreateQueryI'm hoping this structure will make it easier to add more tests going forward!
Coverage is up from
69.42%to80.99%