feat(queryObserver): add isInitialLoading derived flag#4244
Merged
TkDodo merged 5 commits intoTanStack:mainfrom Sep 30, 2022
Merged
feat(queryObserver): add isInitialLoading derived flag#4244TkDodo merged 5 commits intoTanStack:mainfrom
TkDodo merged 5 commits intoTanStack:mainfrom
Conversation
this flag describes isLoading && isFetching and can be used to show a loading spinner for lazy or disabled queries
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b53b413:
|
Codecov ReportBase: 96.36% // Head: 96.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4244 +/- ##
==========================================
+ Coverage 96.36% 96.46% +0.10%
==========================================
Files 45 73 +28
Lines 2281 2972 +691
Branches 640 818 +178
==========================================
+ Hits 2198 2867 +669
- Misses 80 103 +23
+ Partials 3 2 -1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
apparently, v3 has a fix: actions/setup-node#543
DamianOsipiuk
approved these changes
Sep 29, 2022
as described here: https://stackoverflow.com/questions/52015748/npm-failed-to-replace-env-in-config-npm-token he extra warn output made the caching fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this flag describes isLoading && isFetching and can be used to show a loading spinner for lazy or disabled queries
refs #3584
refs #3975