Skip to content

Feature/pnpm#4237

Merged
TkDodo merged 23 commits intoTanStack:mainfrom
TkDodo:feature/pnpm
Sep 28, 2022
Merged

Feature/pnpm#4237
TkDodo merged 23 commits intoTanStack:mainfrom
TkDodo:feature/pnpm

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Sep 28, 2022

No description provided.

which was only needed for yarn workspaces; also, remove the csb workaround, because it didn't work with private:true
because pnpm will replace them automatically during publish
we will always get the latest version as there is no lockfile for them
this also means we don't need to update package.json at all because we use workspace dependencies now
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Sep 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 451d3e2:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration

@TkDodo TkDodo marked this pull request as ready for review September 28, 2022 12:36
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 96.36% // Head: 96.63% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (1393235) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4237      +/-   ##
==========================================
+ Coverage   96.36%   96.63%   +0.27%     
==========================================
  Files          45       73      +28     
  Lines        2281     2969     +688     
  Branches      640      817     +177     
==========================================
+ Hits         2198     2869     +671     
- Misses         80       98      +18     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/devtools/tests/utils.tsx
src/react/setBatchUpdatesFn.ts
src/core/subscribable.ts
src/core/utils.ts
src/react/utils.ts
src/core/mutationObserver.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/react/logger.ts
src/core/infiniteQueryBehavior.ts
src/react/Hydrate.tsx
... and 108 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sachinraja
Copy link
Copy Markdown
Contributor

I tried pnpm --filter "./packages/**" install and it worked fine with this message as output:

➜  react-query git:(feature/pnpm) pnpm --filter "./packages/**" install
Scope: 9 of 32 workspace projects
Lockfile is up to date, resolution step is skipped

@TkDodo
Copy link
Copy Markdown
Collaborator Author

TkDodo commented Sep 28, 2022

@sachinraja you're right, it worked. Not sure sure what I did wrong before:

@TkDodo
Copy link
Copy Markdown
Collaborator Author

TkDodo commented Sep 28, 2022

hm but now I'm getting errors like rollup: not found because we have that defined as dependency in the top-level package.json. Is there a way to include the top-level dependencies, too?

as it doesn't install top-level dependencies; also, --frozen-lockfile is the default for CI environments
@TkDodo TkDodo merged commit dce2815 into TanStack:main Sep 28, 2022
@TkDodo TkDodo deleted the feature/pnpm branch September 28, 2022 16:07
@p6l-richard
Copy link
Copy Markdown

p6l-richard commented Sep 28, 2022

Is there a way to include the top-level dependencies, too?

I got curious as well and for anyone reading this here: @juliusmarminge
added this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants