fix(devtools): make sure that sort function is properly read from localStorage#3703
Merged
TkDodo merged 3 commits intoTanStack:betafrom Jul 17, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #3703 +/- ##
==========================================
- Coverage 97.11% 96.81% -0.31%
==========================================
Files 50 57 +7
Lines 2391 2668 +277
Branches 706 784 +78
==========================================
+ Hits 2322 2583 +261
- Misses 67 83 +16
Partials 2 2
Continue to review full report at Codecov.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f50c04c:
|
9c6e28f to
c0587ff
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s when the returned element is not used for assertions
c0587ff to
f6d93cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #3639: DevTools doesn't remember the sort function
This effect is causing the problem. Good news is that it's also completely unneeded as it's doubling what's already done via useLocalStorage. And if the runs after (which it usually does), it disregards the value that's read by
useLocalStoragehook - which is exactly what causes the bug.This is easily fixable by simply removing the effect.