Fix coderabbit suggestion

danielpza · danielpza · commit a2f221c0de9d · 2026-02-24T11:49:57.000-08:00
diff --git a/packages/eslint-plugin-query/src/rules/prefer-query-options/prefer-query-options.utils.ts b/packages/eslint-plugin-query/src/rules/prefer-query-options/prefer-query-options.utils.ts
@@ -7,7 +7,7 @@ const MAIN_QUERY_PROPERTIES = ['queryKey', 'queryFn']
  * @returns true if the node is an object that has main query options (ie queryKey or queryFn).
  * This is used for detecting inline query options in hooks and functions
  */
-export function detectQueryOptionsInObject(queryNode: TSESTree.Node) {
+export function detectQueryOptionsInObject(queryNode: TSESTree.Node): boolean {
   // skip if it's not an object
   if (queryNode.type !== AST_NODE_TYPES.ObjectExpression) return false
 
@@ -19,5 +19,5 @@ export function detectQueryOptionsInObject(queryNode: TSESTree.Node) {
       MAIN_QUERY_PROPERTIES.includes(property.key.name),
   )
 
-  return hasMainQueryProperties
+  return !!hasMainQueryProperties
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ const MAIN_QUERY_PROPERTIES = ['queryKey', 'queryFn']`
`7`	`7`	`* @returns true if the node is an object that has main query options (ie queryKey or queryFn).`
`8`	`8`	`* This is used for detecting inline query options in hooks and functions`
`9`	`9`	`*/`
`10`		`-export function detectQueryOptionsInObject(queryNode: TSESTree.Node) {`
	`10`	`+export function detectQueryOptionsInObject(queryNode: TSESTree.Node): boolean {`
`11`	`11`	`// skip if it's not an object`
`12`	`12`	`if (queryNode.type !== AST_NODE_TYPES.ObjectExpression) return false`
`13`	`13`
`@@ -19,5 +19,5 @@ export function detectQueryOptionsInObject(queryNode: TSESTree.Node) {`
`19`	`19`	`MAIN_QUERY_PROPERTIES.includes(property.key.name),`
`20`	`20`	`)`
`21`	`21`
`22`		`- return hasMainQueryProperties`
	`22`	`+ return !!hasMainQueryProperties`
`23`	`23`	`}`