fixup! fix(eslint-plugin): exhaustive-deps with variables and type assertions (#9643)

fbieler · fbieler · commit 877669f6d600 · 2025-09-25T18:44:37.000+02:00
diff --git a/packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.rule.ts b/packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.rule.ts
@@ -166,7 +166,14 @@ function getQueryFnRelevantNode(queryFn: TSESTree.Property) {
 }
 
 function dereferenceVariablesAndTypeAssertions(queryKeyNode: TSESTree.Node, context: Readonly<TSESLint.RuleContext<string, ReadonlyArray<unknown>>>) {
-  for (let i = 0; i < (1 << 16); ++i) {
+  const visitedNodes = new Set<TSESTree.Node>()
+
+  for (let i = 0; i < (1 << 8); ++i) {
+    if (visitedNodes.has(queryKeyNode)) {
+      return queryKeyNode
+    }
+    visitedNodes.add(queryKeyNode)
+
     switch (queryKeyNode.type) {
       case AST_NODE_TYPES.TSAsExpression:
         queryKeyNode = queryKeyNode.expression
@@ -187,5 +194,5 @@ function dereferenceVariablesAndTypeAssertions(queryKeyNode: TSESTree.Node, cont
         return queryKeyNode
     }
   }
-  throw new Error('Recursion limit reached.')
+  return queryKeyNode
 }

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,14 @@ function getQueryFnRelevantNode(queryFn: TSESTree.Property) {`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`function dereferenceVariablesAndTypeAssertions(queryKeyNode: TSESTree.Node, context: Readonly<TSESLint.RuleContext<string, ReadonlyArray<unknown>>>) {`
`169`		`- for (let i = 0; i < (1 << 16); ++i) {`
	`169`	`+ const visitedNodes = new Set<TSESTree.Node>()`
	`170`	`+`
	`171`	`+ for (let i = 0; i < (1 << 8); ++i) {`
	`172`	`+ if (visitedNodes.has(queryKeyNode)) {`
	`173`	`+ return queryKeyNode`
	`174`	`+ }`
	`175`	`+ visitedNodes.add(queryKeyNode)`
	`176`	`+`
`170`	`177`	`switch (queryKeyNode.type) {`
`171`	`178`	`case AST_NODE_TYPES.TSAsExpression:`
`172`	`179`	`queryKeyNode = queryKeyNode.expression`
`@@ -187,5 +194,5 @@ function dereferenceVariablesAndTypeAssertions(queryKeyNode: TSESTree.Node, cont`
`187`	`194`	`return queryKeyNode`
`188`	`195`	`}`
`189`	`196`	`}`
`190`		`- throw new Error('Recursion limit reached.')`
	`197`	`+ return queryKeyNode`
`191`	`198`	`}`