Skip to content

feat(FormSkeleton): Support skeleton without buttons#3390

Merged
gjou-tlnd merged 3 commits intomasterfrom
gjou/feat/forms_skeleton_without_buttons
Aug 18, 2021
Merged

feat(FormSkeleton): Support skeleton without buttons#3390
gjou-tlnd merged 3 commits intomasterfrom
gjou/feat/forms_skeleton_without_buttons

Conversation

@gjou-tlnd
Copy link
Copy Markdown
Contributor

@gjou-tlnd gjou-tlnd commented Aug 18, 2021

What is the problem this PR is trying to solve?

We have use-cases where buttons are not displayed inside the form (like Stepper forms).

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@gjou-tlnd gjou-tlnd force-pushed the gjou/feat/forms_skeleton_without_buttons branch 2 times, most recently from 9cc1923 to 753ed37 Compare August 18, 2021 12:15
@gjou-tlnd gjou-tlnd force-pushed the gjou/feat/forms_skeleton_without_buttons branch from 753ed37 to e1ae8f9 Compare August 18, 2021 12:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021

3390

:octocat: Demo is available here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021 •
edited
Loading

Size Change: +179 B (0%)

Total Size: 2.24 MB

Filename Size Change
./packages/containers/dist/TalendReactContainers.js 59.7 kB +53 B (0%)
./packages/containers/dist/TalendReactContainers.min.js 25.4 kB +20 B (0%)
./packages/forms/dist/TalendReactForms.js 311 kB +69 B (0%)
./packages/forms/dist/TalendReactForms.min.js 114 kB +37 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 6.37 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 224 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 2.56 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 224 B
./packages/cmf/dist/TalendReactCmf.js 93.6 kB
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 421 B
./packages/cmf/dist/TalendReactCmf.min.js 31.5 kB
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 419 B
./packages/components/dist/TalendReactComponents.css 33.3 kB
./packages/components/dist/TalendReactComponents.js 464 kB
./packages/components/dist/TalendReactComponents.js.dependencies.json 775 B
./packages/components/dist/TalendReactComponents.min.js 201 kB
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 776 B
./packages/containers/dist/TalendReactContainers.css 534 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 412 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 415 B
./packages/datagrid/dist/TalendReactDatagrid.css 11.4 kB
./packages/datagrid/dist/TalendReactDatagrid.js 60 kB
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 372 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 18.8 kB
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 375 B
./packages/forms/dist/TalendReactForms.css 4.71 kB
./packages/forms/dist/TalendReactForms.js.dependencies.json 486 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 482 B
./packages/icons/dist/bundle.js 2.4 kB
./packages/icons/dist/info.js 1.96 kB
./packages/icons/dist/react.esm.js 185 kB
./packages/icons/dist/react.js 186 kB
./packages/icons/dist/talend-icons-webfont.css 2.86 kB
./packages/icons/dist/talendicons.css 199 B
./packages/icons/dist/TalendIcons.js 191 kB
./packages/icons/dist/TalendIcons.js.dependencies.json 107 B
./packages/icons/dist/TalendIcons.min.js 188 kB
./packages/icons/dist/TalendIcons.min.js.dependencies.json 109 B
./packages/sagas/dist/TalendReactSagas.js 2.5 kB
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 168 B
./packages/sagas/dist/TalendReactSagas.min.js 924 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 170 B
./packages/stepper/dist/TalendReactStepper.js 4.83 kB
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 343 B
./packages/stepper/dist/TalendReactStepper.min.js 1.83 kB
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 342 B
./packages/theme/dist/bootstrap.css 26.8 kB
./packages/theme/dist/bootstrap.js 358 B
./packages/theme/dist/bootstrap.js.dependencies.json 23 B

compressed-size-action

frassinier
frassinier approved these changes Aug 18, 2021
View reviewed changes
Comment thread packages/forms/src/FormSkeleton.js Outdated
Comment thread packages/forms/src/FormSkeleton.js Outdated
gjou-tlnd and others added 2 commits August 18, 2021 15:48
@gjou-tlnd
Update packages/forms/src/FormSkeleton.js
0131cda 
Co-authored-by: Fabien <frassinier@talend.com>
@gjou-tlnd
Update packages/forms/src/FormSkeleton.js
8d8a15a 
Co-authored-by: Fabien <frassinier@talend.com>
@gjou-tlnd gjou-tlnd merged commit e98354d into master Aug 18, 2021
@gjou-tlnd gjou-tlnd deleted the gjou/feat/forms_skeleton_without_buttons branch August 18, 2021 15:44
@github-actions github-actions bot mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@frassinier frassinier frassinier approved these changes

@sgangnant sgangnant sgangnant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gjou-tlnd @frassinier @sgangnant