Skip to content

feat(containers/ComponentForm): Call onChange/onSubmit props#3389

Merged
gjou-tlnd merged 1 commit intomasterfrom
gjou/feat/call_event_props_in_form_container
Aug 18, 2021
Merged

feat(containers/ComponentForm): Call onChange/onSubmit props#3389
gjou-tlnd merged 1 commit intomasterfrom
gjou/feat/call_event_props_in_form_container

Conversation

@gjou-tlnd
Copy link
Copy Markdown
Contributor

@gjou-tlnd gjou-tlnd commented Aug 18, 2021 •
edited by jmfrancois
Loading

What is the problem this PR is trying to solve?

It's not possible to use onChange/onSubmit props with the containers component, which is needed for some use case where we don't want to rely on sagas

What is the chosen solution to this problem?

add support for props.onSubmit and props.onChange in the container

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@gjou-tlnd gjou-tlnd force-pushed the gjou/feat/call_event_props_in_form_container branch from 3be8396 to 0ccc38b Compare August 18, 2021 11:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021 •
edited
Loading

Size Change: +31 B (0%)

Total Size: 2.24 MB

Filename Size Change
./packages/containers/dist/TalendReactContainers.js 59.6 kB +21 B (0%)
./packages/containers/dist/TalendReactContainers.js.dependencies.json 414 B +2 B (0%)
./packages/containers/dist/TalendReactContainers.min.js 25.4 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 6.37 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 224 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 2.56 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 224 B
./packages/cmf/dist/TalendReactCmf.js 93.6 kB
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 421 B
./packages/cmf/dist/TalendReactCmf.min.js 31.5 kB
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 419 B
./packages/components/dist/TalendReactComponents.css 33.3 kB
./packages/components/dist/TalendReactComponents.js 464 kB
./packages/components/dist/TalendReactComponents.js.dependencies.json 775 B
./packages/components/dist/TalendReactComponents.min.js 201 kB
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 776 B
./packages/containers/dist/TalendReactContainers.css 534 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 415 B
./packages/datagrid/dist/TalendReactDatagrid.css 11.4 kB
./packages/datagrid/dist/TalendReactDatagrid.js 60 kB
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 372 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 18.8 kB
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 375 B
./packages/forms/dist/TalendReactForms.css 4.71 kB
./packages/forms/dist/TalendReactForms.js 311 kB
./packages/forms/dist/TalendReactForms.js.dependencies.json 486 B
./packages/forms/dist/TalendReactForms.min.js 114 kB
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 482 B
./packages/icons/dist/bundle.js 2.4 kB
./packages/icons/dist/info.js 1.96 kB
./packages/icons/dist/react.esm.js 185 kB
./packages/icons/dist/react.js 186 kB
./packages/icons/dist/talend-icons-webfont.css 2.86 kB
./packages/icons/dist/talendicons.css 199 B
./packages/icons/dist/TalendIcons.js 191 kB
./packages/icons/dist/TalendIcons.js.dependencies.json 107 B
./packages/icons/dist/TalendIcons.min.js 188 kB
./packages/icons/dist/TalendIcons.min.js.dependencies.json 109 B
./packages/sagas/dist/TalendReactSagas.js 2.5 kB
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 168 B
./packages/sagas/dist/TalendReactSagas.min.js 924 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 170 B
./packages/stepper/dist/TalendReactStepper.js 4.83 kB
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 343 B
./packages/stepper/dist/TalendReactStepper.min.js 1.83 kB
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 342 B
./packages/theme/dist/bootstrap.css 26.8 kB
./packages/theme/dist/bootstrap.js 358 B
./packages/theme/dist/bootstrap.js.dependencies.json 23 B

compressed-size-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2021

3389

:octocat: Demo is available here

@gjou-tlnd gjou-tlnd merged commit 47de7e4 into master Aug 18, 2021
@gjou-tlnd gjou-tlnd deleted the gjou/feat/call_event_props_in_form_container branch August 18, 2021 13:48
@github-actions github-actions bot mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@frassinier frassinier frassinier approved these changes

@sgangnant sgangnant sgangnant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gjou-tlnd @frassinier @sgangnant