Skip to content

Add Nix path to ffmpeg locations on macOS #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyanVoxel merged 2 commits into from
Aug 4, 2025
Merged

Add Nix path to ffmpeg locations on macOS #990

CyanVoxel merged 2 commits into from
Aug 4, 2025

Conversation

@thibmaek
Copy link

@thibmaek thibmaek commented Jul 14, 2025

Summary

ffmpeg was installed on my system using Nix (package manager, not NixOS) but undetected by TagStudio.
I added the path pointing to where Nix installs these binaries to the list of mac locations.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Installation Installing, building, and/or launching the program labels Jul 14, 2025
@xarvex
Copy link
Member

xarvex commented Jul 15, 2025 •
edited
Loading

Best approach is to check the PATH for ffmpeg, which I'm surprised isn't happening for macOS. This location is not guaranteed to be used on all Nix installations, other paths are used instead, especially when factoring in nix-darwin and home-manager.

Not checking the PATH for ffmpeg also means that installing TagStudio with Nix (which should be possible as I account for darwin, but I do not have a Mac to test) might break.

@CyanVoxel
Copy link
Member

CyanVoxel commented Aug 2, 2025

Best approach is to check the PATH for ffmpeg, which I'm surprised isn't happening for macOS. This location is not guaranteed to be used on all Nix installations, other paths are used instead, especially when factoring in nix-darwin and home-manager.

Not checking the PATH for ffmpeg also means that installing TagStudio with Nix (which should be possible as I account for darwin, but I do not have a Mac to test) might break.

Just for some documented clarification on this: macOS applications launched from the GUI (i.e. launched outside of a terminal) don't have access to the system PATH. That's why for FFmpeg we had to start keeping a list of all commonly known install locations.

@thibmaek Any updates on the failing workflow checks? I could provide some assistance if needed.

@thibmaek
Copy link
Author

thibmaek commented Aug 3, 2025

@CyanVoxel forgot to import os since I edited the file with Neovim 😅
Should pass now!

CyanVoxel
CyanVoxel approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition!

@CyanVoxel CyanVoxel merged commit 1459f79 into TagStudioDev:main Aug 4, 2025
5 checks passed
@Computerdores Computerdores moved this to ✅ Done in TagStudio Development Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees

No one assigned

Labels

Type: Bug Something isn't working as intended Type: Installation Installing, building, and/or launching the program

Projects

TagStudio Development
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thibmaek @xarvex @CyanVoxel