Skip to content

Improve main_window.py #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyanVoxel merged 1 commit into from
Aug 3, 2025
Merged

Improve main_window.py #957

CyanVoxel merged 1 commit into from
Aug 3, 2025

Conversation

@VasigaranAndAngel
Copy link
Collaborator

@VasigaranAndAngel VasigaranAndAngel commented Jun 12, 2025

Summary

  • Adds type annotations to the MainWindow class in main_window.py to address Pyright's reportUninitializedInstanceVariable warning and few more type improvements,
  • Removes two overridden methods that appear to be unused.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Refactor Code that needs to be restructured or cleaned up Status: Review Needed A review of this is needed labels Jun 12, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Jun 12, 2025
CyanVoxel
CyanVoxel approved these changes Aug 3, 2025
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on reviewing this, thank you for the changes here!

@CyanVoxel CyanVoxel merged commit 6b96ee7 into TagStudioDev:main Aug 3, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🏓 Ready for Review to ✅ Done in TagStudio Development Aug 3, 2025
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees

No one assigned

Labels

Type: Refactor Code that needs to be restructured or cleaned up

Projects

TagStudio Development
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VasigaranAndAngel @CyanVoxel