Skip to content

Conversation

@Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Jun 7, 2025

Summary

Splits the style guide into a separate file, and documents the intended future structure of the qt part of the code base.

Tasks Completed

Not applicable

@Computerdores
Copy link
Collaborator Author

class structure guide inspired by: https://www.pythonguis.com/tutorials/pyside6-modelview-architecture/

@Computerdores Computerdores marked this pull request as draft June 7, 2025 12:42
@Computerdores Computerdores changed the title doc: first draft doc: Add QT MVC structure to style guide Jun 7, 2025
@Computerdores Computerdores requested a review from CyanVoxel June 7, 2025 13:23
@Computerdores Computerdores marked this pull request as ready for review June 7, 2025 13:23
@Computerdores Computerdores marked this pull request as draft June 7, 2025 19:44
@CyanVoxel CyanVoxel added Type: Documentation Additions/changes to documentation Priority: High An important issue requiring attention labels Jun 7, 2025
@CyanVoxel CyanVoxel moved this to 👀 In review in TagStudio Development Jun 7, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking very good so far, just a couple of early nits and comments

@Computerdores Computerdores marked this pull request as ready for review June 7, 2025 22:03
@Computerdores
Copy link
Collaborator Author

I have now added everything I wanted to and thus this is ready for final review

@Computerdores Computerdores requested a review from CyanVoxel June 30, 2025 17:29
@CyanVoxel CyanVoxel self-assigned this Jul 3, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe everything looks good here, thank you for your work on this!

@CyanVoxel CyanVoxel merged commit 7176908 into TagStudioDev:main Jul 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in TagStudio Development Jul 5, 2025
@Computerdores Computerdores deleted the doc/style-guide-qt-mvc branch July 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: High An important issue requiring attention Type: Documentation Additions/changes to documentation

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants