fix: KeyError when formatting translation #829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
CyanVoxel
reviewed
Mar 4, 2025
Collaborator
Author
|
Closing in favor of #830. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #827. I implemented a string subclass that handles the formatting differently. I did it that way because it keeps the Translator API simpler and when formatting the translation one can just use the normal way without having to look for a specific method, as opposed to creating a custom formatting method for
Translator.The formatting also formats all keys that a value is present for as opposed to the previous implementation (removed in #817) that didn't substitute any placeholders if the value for one of them wasn't specified.
Tasks Completed