Skip to content

Conversation

@SumithSudheer
Copy link
Contributor

Summary

fix : Empty frame as video preview if auto-play is paused #1053

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience labels Aug 25, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Aug 25, 2025
@CyanVoxel CyanVoxel linked an issue Aug 25, 2025 that may be closed by this pull request
3 tasks
@CyanVoxel
Copy link
Member

Thank you for this PR! When testing I realized that the original report for #1053 actually under-reported the bug, and the issue is also present when the player is in the paused state and a new video is clicked (see this comment):

I've noticed that it's not just an issue when autoplay is toggled off, but also the general pause state. If the player is paused, regardless of the autoplay state, the next video clicked also does not have the first frame loaded.

Would you be willing to look into this as well for this PR?

@SumithSudheer
Copy link
Contributor Author

Thank you for this PR! When testing I realized that the original report for #1053 actually under-reported the bug, and the issue is also present when the player is in the paused state and a new video is clicked (see this comment):

I've noticed that it's not just an issue when autoplay is toggled off, but also the general pause state. If the player is paused, regardless of the autoplay state, the next video clicked also does not have the first frame loaded.

Would you be willing to look into this as well for this PR?
Thanks for catching that! 🙏
Yes, I’m willing to look into the paused state scenario as well. I’ll update this PR to handle both autoplay being disabled and the general paused state so that the first frame loads correctly when a new video is clicked.

I’ll push the changes once I’ve tested them locally. 👍

@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Aug 28, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.4 milestone Aug 28, 2025
…xt video clicked also does not have the first frame loaded.
@CyanVoxel
Copy link
Member

There now seems to be a regression where having autoplay checked and the player paused causes the original behavior:
image

Meanwhile having autoplay unchecked loads the first frame as desired.

@CyanVoxel CyanVoxel added the Thumbs/Previews File thumbnails or previews label Aug 30, 2025
@CyanVoxel CyanVoxel modified the milestones: Alpha v9.5.4, Alpha v9.5.5 Aug 31, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in TagStudio Development Sep 6, 2025
@CyanVoxel
Copy link
Member

Closed in favor of #1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Thumbs/Previews File thumbnails or previews Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Empty frame as video preview if auto-play is paused

2 participants