Conversation
jchate6
approved these changes
Feb 19, 2026
Contributor
jchate6
left a comment
There was a problem hiding this comment.
This looks good. A couple questions:
It looks like we loose all of our icons and css things when we set debug = False. Do you understand why this happens? I think that also means I can't test making my own local 404 page.
Contributor
Author
|
Turning off debug switches how static files are served: they won’t be served by the development server anymore. It does make it a pain to test the custom 404 page. That’s why all the styling is inline in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wow! the issue number is #1404 coincidence?