Update target grouping table#1408
Merged
jchate6 merged 12 commits into1111-build-htmx-table-widgetfrom Feb 13, 2026
Merged
Conversation
phycodurus
approved these changes
Feb 13, 2026
| (to the object's detail page) rather than being intercepted by HTMX. [3]_ | ||
| (to the object's detail page) rather than being intercepted by HTMX. [2]_ | ||
|
|
||
| See the example in `tom_targets/tables.py <https://github.com/TOMToolkit/tom_base/tree/dev/tom_targets>`_. |
Member
There was a problem hiding this comment.
This link can be made specific to the the relevant line number once this PR has been merged into the (more permanent) dev branch
| ) | ||
| ) | ||
| return self._form | ||
| See the example in `tom_targets/views.py <https://github.com/TOMToolkit/tom_base/blob/dev/tom_targets/views.py>`_. |
Member
There was a problem hiding this comment.
Another link that could include a line number after the PR is merged
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Subclass ``HTMXTableFilterSet`` from ``tom_common.htmx_table``. The base | ||
| class provides a General Search text field (``query``) with debounced |
Member
There was a problem hiding this comment.
I"m not attached to query as the name of this field. Open to suggestions.
Contributor
Author
There was a problem hiding this comment.
This would be better as general_search or something, but this conflicts with the method name, and I'm not going to worry about it right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The excuse for this PR is to add an HTMX table to target groupings.
This also substantially re-works the docs, and changes some of the base htmx classes.
The motivation for this was to make the architecture and the docs more user friendly, extracting basic functions to the toolkit to make it easier to get started and make it more clear what extra features are supported.
I did not update the Targets table to use any of these simplification functions. They stand as good examples to doing it the "hard" way.
For the Target Groups Table, I did not include sharing. This will need to be added to retain functionality, but optional columns seemed like more work than I was willing to put in, and the goal for the (hopefully) near future is to add a standard "actions" drop down whenever checkboxes are included.
The docs could probably still use more internal references, but from the weeds it's pretty hard to see exactly where these should go.
Comments about the HTMX table: