Skip to content

Merge (sorting) sub-issue in to (htmx table widget) parent-issue #1374

Merged
phycodurus merged 10 commits into1111-build-htmx-table-widgetfrom
1368-htmx-target-table-sorting
Jan 12, 2026
Merged

Merge (sorting) sub-issue in to (htmx table widget) parent-issue #1374
phycodurus merged 10 commits into1111-build-htmx-table-widgetfrom
1368-htmx-target-table-sorting

Conversation

@phycodurus
Copy link
Copy Markdown
Member

Merges the branch for the sorting sub-issue

into the branch for the parent issue

We're not merging in to dev just yet. So, I'm not expecting a super in-depth review; that can wait for the parent issue branch merge-to-dev. This is mostly to keep everyone in the loop.

we've only set the Meta.{model, fields, template_name} properties
and the partial that renders only the table
(vs. whole page with table)
also store table-rendering partial in class to allow this
to be overridden. (This might be removed in the future if
if is not useful).
If the request came from HTMX, just load the partial (the table),
not the whole page.
@phycodurus phycodurus requested review from Fingel and jchate6 January 12, 2026 19:41
@phycodurus phycodurus linked an issue Jan 12, 2026 that may be closed by this pull request
@phycodurus phycodurus moved this to Needs Review in TOM Toolkit Jan 12, 2026
Copy link
Copy Markdown
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to update dependencies.

@phycodurus phycodurus requested a review from jchate6 January 12, 2026 23:26
@phycodurus phycodurus merged commit 20a9b66 into 1111-build-htmx-table-widget Jan 12, 2026
22 of 23 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Merged (to dev) in TOM Toolkit Jan 12, 2026
@phycodurus phycodurus deleted the 1368-htmx-target-table-sorting branch January 12, 2026 23:27
@jchate6 jchate6 moved this from Merged (to dev) to Released in TOM Toolkit Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

htmx target table: sorting

2 participants