Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TNG/ArchUnit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.13.0
Choose a base ref
...
head repository: TNG/ArchUnit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.13.1
Choose a head ref
  • 7 commits
  • 17 files changed
  • 1 contributor

Commits on Jan 10, 2020

  1. adjust release check for changed artifacts

    The POMs were adjusted to the upgraded dependencies and an expected POM for `archunit-junit5` was added.
    
    Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    codecholeric committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    444306d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. fix JUnit 5 docs

    Unfortunately there were some leftover docs from the time before ArchUnit released the aggregator Maven dependency for both `archunit-junit5-api` and `archunit-junit5-engine`. The section can now actually be simplified, because meanwhile there is nothing specific as compared to JUnit 4, if the aggregator artifact is used.
    
    Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    codecholeric committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    5fac419 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. adjust version for 0.13.1-SNAPSHOT

    Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    codecholeric committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    27e4251 View commit details
    Browse the repository at this point in the history
  2. fix broken JRT URL handling for JDK >= 13

    With JDK 13 some wrongly implemented behavior of JRT path handling was fixed. I.e. by JEP-220 (https://openjdk.java.net/jeps/220) while URIs possess the shape of `jrt:/module.name/some/clazz/Name.class` the respective (virtual) file system path for JRTs supposedly has the shape of `/modules/module.name/some/clazz/Name.class`. Unfortunately ArchUnit was relying on the wrongly implemented version of `JrtFileSystemProvider` which would return a path for JRTs of `/module.name/some/clazz/Name.class`. Thus with JDK >= 13 the URI handling for JRTs was broken.
    This will now be fixed by relying on pure JRT URI handling without relying on conversion to `java.nio.file.Path`. We simply split the path of a JRT URI on `/` and treat the first segment as module name, the rest of the segments as the resource/class name (e.g. `module.name` and `some/clazz/Name.class`). Note that we unfortunately cannot use `URI.getPath()` within `NormalizedUri` to retrieve the path without the schema, since `URI.getPath()` will return `null` for JAR URIs (i.e. `jar:file:/...`).
    
    Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    codecholeric committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    852c808 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #304 from TNG/bugfix/fix-jdk13-module-name-resolution

    fix broken JRT URL handling for JDK >= 13
    codecholeric authored Jan 31, 2020
    Configuration menu
    Copy the full SHA
    51087d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. adjust docs to release version 0.13.1

    Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    codecholeric committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    9bfc075 View commit details
    Browse the repository at this point in the history
  2. create release news for 0.13.1

    Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
    codecholeric committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    b928082 View commit details
    Browse the repository at this point in the history
Loading