fix: add libudev-dev to dependency installation for improved compatib…#550
fix: add libudev-dev to dependency installation for improved compatib…#550felix-schultz merged 1 commit intoalphafrom
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Code Review
This pull request updates the setup-environment GitHub Action to include libudev-dev in the installed packages. The reviewer suggests incrementing the cache version to ensure the new dependency is correctly picked up and recommends using a YAML folded block scalar for improved readability of the package list.
| uses: awalsh128/cache-apt-pkgs-action@latest | ||
| with: | ||
| packages: libgtk-3-dev libclang-dev libjavascriptcoregtk-4.1-dev libsoup-3.0-dev pkg-config protobuf-compiler webkit2gtk-4.1 libglib2.0-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libxcb1-dev libxrandr-dev libdbus-1-dev libpipewire-0.3-dev libwayland-dev libegl-dev | ||
| packages: libgtk-3-dev libclang-dev libjavascriptcoregtk-4.1-dev libsoup-3.0-dev pkg-config protobuf-compiler webkit2gtk-4.1 libglib2.0-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libxcb1-dev libxrandr-dev libdbus-1-dev libpipewire-0.3-dev libwayland-dev libegl-dev libudev-dev |
There was a problem hiding this comment.
When adding a new dependency to the packages list, it is important to increment the version on line 32 (e.g., to 1.1) to invalidate the existing cache. If the version is not updated, GitHub Actions may use a previously cached environment that lacks libudev-dev, which would prevent the fix from being applied in workflows where a cache already exists.
Additionally, consider using a YAML folded block scalar (>-) to list the packages. This significantly improves readability and makes it easier to manage dependencies in the future.
packages: >-
libgtk-3-dev
libclang-dev
libjavascriptcoregtk-4.1-dev
libsoup-3.0-dev
pkg-config
protobuf-compiler
webkit2gtk-4.1
libglib2.0-dev
libwebkit2gtk-4.1-dev
libappindicator3-dev
librsvg2-dev
patchelf
libxcb1-dev
libxrandr-dev
libdbus-1-dev
libpipewire-0.3-dev
libwayland-dev
libegl-dev
libudev-dev
…ility