Skip to content

Fix and Biome#508

Merged
felix-schultz merged 1 commit intodevfrom
task/505-md-embedded-charts-need-dark-light-mode-version
Feb 13, 2026
Merged

Fix and Biome#508
felix-schultz merged 1 commit intodevfrom
task/505-md-embedded-charts-need-dark-light-mode-version

Conversation

@felix-schultz
Copy link
Copy Markdown
Member

This pull request primarily consists of code formatting improvements across multiple files in both the desktop and web applications. The changes focus on making code more readable and consistent, with no functional or behavioral modifications introduced.

The most important changes are:

Code Formatting and Readability:

JSON and Localization Cleanups:

  • Minified and reformatted the assetlinks.json file and various i18n localization files for consistency and easier maintenance. [1] [2] [3] [4] [5] [6]

No logic or functionality has been altered; these are strictly formatting and style improvements for better codebase maintainability.

@felix-schultz felix-schultz linked an issue Feb 13, 2026 that may be closed by this pull request
@felix-schultz felix-schultz merged commit b66e7fd into dev Feb 13, 2026
6 of 13 checks passed
@felix-schultz felix-schultz deleted the task/505-md-embedded-charts-need-dark-light-mode-version branch February 13, 2026 11:21
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @felix-schultz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses entirely on code quality and consistency through extensive formatting improvements. It standardizes code style across various components and configuration files in both desktop and web applications, and introduces dynamic theming for chart visualizations. No functional changes or new features have been introduced, ensuring a cleaner and more maintainable codebase.

Highlights

  • Code Formatting and Readability: Multiple React components and utility functions across desktop and web applications have been reformatted. This includes multi-line function calls, object literals, array dependencies, and various JSX attributes to improve code consistency and readability.
  • JSON and Localization Cleanups: The assetlinks.json file has been minified and several i18n localization files have been reformatted. These changes ensure consistency and simplify future maintenance of these configuration and translation assets.
  • Theming for Chart Components: Nivo and Plotly chart preview components now dynamically adjust their themes based on the resolved application theme (dark/light mode), ensuring visual consistency across the UI.
Changelog
  • apps/desktop/app/layout.tsx
    • Reformated HTML tag attributes for better readability.
  • apps/desktop/app/library/config/layout.tsx
    • Reformated a conditional return statement for clarity.
    • Adjusted the formatting of a useMemo dependency array.
  • apps/desktop/app/store/components/useStoreData.ts
    • Reformated a conditional return statement for improved readability.
  • apps/desktop/components/app-sidebar.tsx
    • Reformated the paddingBottom style property for better alignment.
  • apps/desktop/components/auth-provider.tsx
    • Reformated an import statement to span multiple lines.
    • Adjusted the formatting of a console.log statement.
  • apps/desktop/components/ios-webview-hardening.tsx
    • Reformated variable assignments for top and bottom safe area insets.
    • Adjusted the formatting of a try-catch block.
    • Reformated a clamp function call.
    • Updated history.pushState and history.replaceState assignments to arrow functions.
    • Reformated window.visualViewport event listener removals.
  • apps/desktop/components/tauri-provider.tsx
    • Reformated a Promise return type definition.
    • Adjusted the formatting of a ternary operator for apiBase.
  • apps/web/app/library/config/events/page.tsx
    • Reformated a useCallback hook definition.
  • apps/web/app/library/config/layout.tsx
    • Reformated a conditional return statement for clarity.
    • Adjusted the formatting of a useMemo dependency array.
  • apps/web/app/library/config/pages/page.tsx
    • Reformated a useCallback hook definition.
  • apps/web/app/store/components/useStoreData.ts
    • Reformated a conditional return statement for improved readability.
  • apps/web/components/app-sidebar.tsx
    • Reformated the paddingBottom style property for better alignment.
  • apps/web/lib/oauth-service.ts
    • Reformated a ternary operator for normalized URL construction.
  • apps/web/public/.well-known/assetlinks.json
    • Minified the JSON file for reduced size and consistency.
  • apps/website/src/components/backend-provider.tsx
    • Reordered type imports for consistency.
  • apps/website/src/i18n/locales/pages/data-deletion-en.ts
    • Reformated a multi-line string literal.
  • apps/website/src/i18n/locales/pages/data-deletion-es.ts
    • Reformated a multi-line string literal.
  • apps/website/src/i18n/locales/pages/data-deletion-fr.ts
    • Reformated multiple multi-line string literals.
  • apps/website/src/i18n/locales/pages/data-deletion-it.ts
    • Reformated a multi-line string literal.
  • apps/website/src/i18n/locales/pages/data-deletion-ja.ts
    • Reformated a multi-line string literal.
  • apps/website/src/i18n/locales/pages/data-deletion-ko.ts
    • Reformated multiple multi-line string literals.
  • apps/website/src/i18n/locales/pages/data-deletion-nl.ts
    • Reformated multiple multi-line string literals.
  • apps/website/src/i18n/locales/pages/data-deletion-pt.ts
    • Reformated a multi-line string literal.
  • apps/website/src/i18n/locales/pages/data-deletion-sv.ts
    • Reformated multiple multi-line string literals.
  • apps/website/src/i18n/locales/pages/data-deletion-zh.ts
    • Reformated multiple multi-line string literals.
  • apps/website/src/lib/seo.ts
    • Reformated a function signature to span multiple lines.
  • apps/website/src/pages/rss.xml.js
    • Reformated a multi-line string literal for description.
  • packages/ui/components/editor/ui/chart-nivo-preview.tsx
    • Added useTheme import for dynamic theming.
    • Removed a static DEFAULT_THEME object.
    • Implemented a useMemo hook to create a theme-aware defaultTheme based on resolvedTheme.
    • Updated chart properties to use the new dynamic defaultTheme.
    • Added labelTextColor property for Bar charts to ensure theme-aware label colors.
  • packages/ui/components/editor/ui/chart-plotly-preview.tsx
    • Added useTheme import for dynamic theming.
    • Updated useMemo hook to apply theme-aware colors to various Plotly layout properties (font, title, legend, axes).
  • packages/ui/components/interfaces/chat-default.tsx
    • Reformated a reconnectSubscribed.current.delete call.
    • Adjusted the formatting of an if condition.
    • Reformated a p tag's content for better readability.
  • packages/ui/components/interfaces/chat-default/chat.tsx
    • Reformated a div tag's attributes for better alignment.
  • packages/ui/components/ui/model-card.tsx
    • Reformated a type definition to span multiple lines.
    • Adjusted the formatting of isEmbeddingBit and supportsRemoteEmbeddingExecution function calls.
  • packages/ui/components/ui/model-detail-sheet.tsx
    • Reordered imports for consistency.
  • packages/ui/components/ui/sidebar.tsx
    • Reformated the paddingBottom style property for better alignment.
  • packages/ui/global.css
    • Reformated CSS variables for safe area insets to improve readability.
  • packages/ui/lib/oauth/service.ts
    • Reformated runtime.httpPost calls for better readability.
  • packages/ui/state/log-aggregation-state.ts
    • Reformated set calls for improved readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily consists of code formatting improvements across a large number of files, which enhances readability and consistency as intended. In addition to the formatting, there are valuable functional improvements in chart-nivo-preview.tsx and chart-plotly-preview.tsx. These changes make the charts theme-aware (light/dark mode), which is a great enhancement to the user experience. The changes are well-implemented and improve the overall quality of the codebase. I have no further suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MD embedded charts need dark / light mode version

1 participant