Skip to content

Fix/rust toolchain#494

Merged
felix-schultz merged 2 commits intoalphafrom
fix/rust-toolchain
Feb 9, 2026
Merged

Fix/rust toolchain#494
felix-schultz merged 2 commits intoalphafrom
fix/rust-toolchain

Conversation

@felix-schultz
Copy link
Copy Markdown
Member

@felix-schultz felix-schultz commented Feb 9, 2026

This pull request makes several configuration and platform-specific adjustments across the desktop and storage packages. The main changes include updating platform and architecture conditions for dependencies, modifying deep link registration logic, and cleaning up Info.plist files. Below are the most important changes, grouped by theme:

Platform-specific configuration updates:

  • Updated the conditional dependency for lancedb in packages/storage/Cargo.toml to only include macOS and Linux on x86_64 and aarch64 architectures, instead of all non-Windows platforms.
  • Changed the deep link registration logic in apps/desktop/src-tauri/src/lib.rs to always include Windows, regardless of debug assertions, aligning behavior across platforms.

Info.plist cleanup:

  • Removed the ITSAppUsesNonExemptEncryption key from both apps/desktop/src-tauri/Info.plist and apps/desktop/src-tauri/gen/apple/flow-like-desktop_iOS/Info.plist, simplifying compliance declarations. [1] [2]

Directory initialization improvements:

  • Changed directory variables in apps/desktop/src-tauri/src/settings.rs to be mutable, preparing them for potential platform-specific modifications.

@felix-schultz felix-schultz merged commit e99ea7e into alpha Feb 9, 2026
0 of 2 checks passed
@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Hello @felix-schultz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the application's configuration and platform-specific behaviors across desktop and storage components. It ensures more precise dependency management, consistent deep link handling, and cleaner Apple application metadata, while also preparing internal directory paths for greater flexibility.

Highlights

  • lancedb Dependency Refinement: The lancedb dependency in packages/storage/Cargo.toml is now conditionally included only for macOS and Linux on x86_64 and aarch64 architectures, narrowing its previous scope of all non-Windows platforms.
  • Deep Link Registration Alignment: The deep link registration logic in apps/desktop/src-tauri/src/lib.rs has been updated to always include Windows, removing the debug_assertions condition for consistency across platforms.
  • Info.plist Cleanup: The ITSAppUsesNonExemptEncryption key has been removed from both apps/desktop/src-tauri/Info.plist and apps/desktop/src-tauri/gen/apple/flow-like-desktop_iOS/Info.plist, simplifying compliance declarations for Apple applications.
  • Mutable Directory Variables: Directory variables (bit_dir, project_dir, user_dir) in apps/desktop/src-tauri/src/settings.rs have been made mutable, allowing for future platform-specific adjustments.
Changelog
  • apps/desktop/src-tauri/Info.plist
    • Removed the ITSAppUsesNonExemptEncryption key.
  • apps/desktop/src-tauri/gen/apple/flow-like-desktop_iOS/Info.plist
    • Removed the ITSAppUsesNonExemptEncryption key.
  • apps/desktop/src-tauri/src/lib.rs
    • Modified the #[cfg] attribute for deep link registration to include windows unconditionally, removing debug_assertions.
  • apps/desktop/src-tauri/src/settings.rs
    • Changed bit_dir, project_dir, and user_dir variables from immutable let to mutable let mut.
  • packages/storage/Cargo.toml
    • Updated the target configuration for lancedb dependency to cfg(all(any(target_os = "macos", target_os = "linux"), any(target_arch = "x86_64", target_arch = "aarch64"))) from cfg(not(target_os = "windows")).
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@felix-schultz felix-schultz deleted the fix/rust-toolchain branch February 9, 2026 06:26
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several configuration and platform-specific adjustments. The changes to Cargo.toml to refine the lancedb dependency, the update to the deep link registration in lib.rs, and the cleanup of Info.plist files are all positive improvements that enhance correctness and maintainability.

My review focuses on an opportunity to refactor the directory path initialization in settings.rs. While the current change to make variables mutable is functional, I've suggested a more idiomatic Rust approach using conditional compilation to initialize these paths immutably, which improves code clarity and robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@felix-schultz