Remove execution pins from Path and Virtual directory nodes for simpl…#383
Merged
felix-schultz merged 1 commit intodevfrom Nov 14, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors several node implementations in the
packages/catalog/src/data/path/dirsdirectory to simplify their execution model. The main change is the removal of the execution pins (exec_inandexec_out) and their associated activation/deactivation logic, making these nodes purely data-producing without explicit execution flow control.Refactoring of node execution model:
Removed
exec_inandexec_outexecution pins from the node definitions incache_dir.rs,storage_dir.rs,user_dir.rs, andvirtual_dir.rs, so these nodes now only expose data pins relevant to their output. [1] [2] [3] [4] [5]Eliminated calls to
activate_exec_pinanddeactivate_exec_pinforexec_outin therunmethods of all affected nodes, streamlining their execution to just produce and set the output path value. [1] [2] [3] [4] [5]