Fix/378 right click context menu sometimes directly places selection node#379
Merged
felix-schultz merged 2 commits intodevfrom Nov 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a mechanism to prevent accidental selection of context menu items immediately after the menu opens, improving the user experience and reducing unintended actions. The main changes involve adding a blocking reference to manage click events, refactoring event handlers to respect this block, and updating component props to pass the blocking state.
Context menu interaction improvements:
menuBlockedRefto bothFlowContextMenuandFlowContextMenuNodescomponents, which temporarily blocks menu item selection for 200ms after the menu opens to prevent accidental triggers. (packages/ui/components/flow/flow-context-menu.tsx,packages/ui/components/flow/flow-context-menu-nodes.tsx) [1] [2]onClick→onSelect) to checkmenuBlockedRef.currentand prevent selection if the block is active, ensuring consistent behavior across all context menu actions. (packages/ui/components/flow/flow-context-menu.tsx,packages/ui/components/flow/flow-context-menu-nodes.tsx) [1] [2] [3] [4]menuBlockedRefthrough nested context menu components, maintaining the blocking state throughout the menu hierarchy. (packages/ui/components/flow/flow-context-menu-nodes.tsx,packages/ui/components/flow/flow-context-menu.tsx) [1] [2]Code quality and minor improvements:
useCallbackforhandleNodePlaceto optimize performance and ensure consistent function references. (packages/ui/components/flow/flow-context-menu.tsx)packages/ui/components/flow/flow-context-menu.tsx)