Skip to content

Node/289 timebox timeout path#377

Merged
felix-schultz merged 2 commits intodevfrom
node/289-timebox-timeout-path
Nov 13, 2025
Merged

Node/289 timebox timeout path#377
felix-schultz merged 2 commits intodevfrom
node/289-timebox-timeout-path

Conversation

@felix-schultz
Copy link
Copy Markdown
Member

This pull request introduces a new timeout control node to the flow control system and makes minor improvements for code consistency and correctness. The most significant change is the addition of the TimeoutNode, which allows execution branches to be managed based on completion within a specified time limit.

Control Node Enhancements

  • Added a new timeout module with the TimeoutNode, enabling execution of a branch with a configurable timeout. The node provides separate outputs for completed and timed-out execution paths, improving flow control flexibility. (packages/catalog/src/control/timeout.rs)
  • Registered the new TimeoutNode in the control node registry so it is available for use in flows. (packages/catalog/src/control.rs) [1] [2]

Minor Code Improvements

  • Used the more idiomatic unwrap_or_else(String::new) instead of a closure for defaulting to an empty string, simplifying the code. (packages/catalog/src/ai/generative/agent/simple.rs)
  • Removed unnecessary .into() conversion when assigning assistant message content, ensuring correct type usage. (packages/catalog/src/ai/generative/agent/simple.rs)
  • Removed an unused import (CompletionModelDyn) from packages/core/src/bit.rs for code cleanliness.

@felix-schultz felix-schultz linked an issue Nov 13, 2025 that may be closed by this pull request
@felix-schultz felix-schultz merged commit 05de5af into dev Nov 13, 2025
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timebox / Timeout Path

1 participant