Fix/208 layer pins cant connect to generics like reroute nodes#225
Merged
felix-schultz merged 2 commits intodevfrom Aug 23, 2025
Merged
Conversation
…nnect_pins command
…ect_pins functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings related to pin connection logic and board iteration in the flow system. The main focus is on making pin lookup and cleanup logic more robust and maintainable, as well as enhancing debugging capabilities.
Pin connection and cleanup logic improvements
main_pin_iterationmethod inFixPinsCleanupto use a single lookup for the owner parent ID, simplifying and improving the reliability of pin connection and dependency cleanup. The code now handles both connected and missing pins more consistently.connect_pins, streamlining the update process for pin dependencies and connections.Board iteration and pin lookup enhancements
Debugging and code clarity improvements
Debugtrait to theNodeOrLayerenum to facilitate easier debugging and logging.is_nodemethod from theNodeOrLayerenum for improved code clarity.