fix: Update EmailAttachmentsNode to handle optional attachments and s…#204
Merged
felix-schultz merged 1 commit intoalphafrom Aug 18, 2025
Merged
fix: Update EmailAttachmentsNode to handle optional attachments and s…#204felix-schultz merged 1 commit intoalphafrom
felix-schultz merged 1 commit intoalphafrom
Conversation
…et correct value type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of email attachments in the
EmailAttachmentsNodelogic to improve type safety and robustness. The main changes focus on how the attachments are represented and processed, ensuring the code handles missing attachment data more gracefully.Attachment handling improvements:
attachmentspin to useValueType::Arrayand set the schema toAttachment, instead of an optional vector of attachments. This makes the expected data type more explicit and consistent.attachmentspin to useemail.attachments.unwrap_or_default(), ensuring that an empty array is used when there are no attachments, preventing potential errors fromNonevalues.