Merged
Conversation
merge dev
merge dev
merge dev
merge dev
merge dev
merge dev
merge dev
merge dev
merge dev
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "Agent" catalog section with a Simple Agent node and supporting infrastructure. The changes implement recursive LLM execution with tool calls, allowing agents to control their own execution flow until a final response is reached.
Key Changes
- Introduced Simple Agent node with recursive LLM invocation and tool call management
- Simplified function call data structures by removing Option wrappers for required fields
- Added new utility nodes for chunk and history creation from strings
- Added input validation for random number generation nodes
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/model-provider/src/response.rs | Simplified FunctionCall and ResponseFunction by removing Option wrappers |
| packages/model-provider/src/history.rs | Added Display trait, tool call deserialization, and system prompt getter |
| packages/catalog/src/utils/json/parse_with_schema.rs | Replaced OpenAI-specific types with generic Tool types |
| packages/catalog/src/ai/generative/agent/simple.rs | New Simple Agent node implementation |
| packages/catalog/src/ai/generative/llm/invoke_with_tools.rs | New tool invocation node replacing with_tools |
| packages/catalog/src/utils/int/random_range.rs | Added min/max validation |
| packages/catalog/src/utils/float/random_range.rs | Added min/max validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
simonjanssen
commented
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog
Nodes
Simple Agent Node
Make Message Node
Chunk From String Node
History From String Node
Random Float/Int
Misc