Merged
Conversation
… and email fetching - Introduced `mail` module with IMAP support, including connection handling and inbox management. - Implemented `ImapConnectNode` for establishing IMAP connections and caching sessions. - Added `ImapInboxNode` for wrapping IMAP mailboxes and listing available inboxes. - Created `ListMailsNode` to fetch email UIDs based on search filters. - Developed `FetchMailNode` to retrieve full email content, including headers and attachments. - Enhanced email handling with structured data types for emails, mail addresses, and attachments. - Updated `PinOptions` to include a sensitive flag for secure handling of sensitive data. - Adjusted Protobuf definitions to accommodate new fields in `PinOptions`. - Updated dependencies in `Cargo.toml` for compatibility with workspace features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and additions across the codebase, focusing on dependency updates, code organization, and new mail functionality. The most significant changes are the addition of mail-related modules and dependencies, updates to existing dependencies, and some code reorganization for clarity and maintainability.
Mail functionality and catalog registration
mailmodule to the catalog, including submodules for IMAP and SMTP functionality, and registered mail-related nodes in the catalog. This enables new mail features in the system. (packages/catalog/src/mail.rs,packages/catalog/src/lib.rs) [1] [2] [3]Dependency updates and additions
packages/catalog/Cargo.toml, including bumping versions fornalgebraandhtmd, and adding new dependencies for mail-related features:async-imap,async-native-tls,async-smtp,tokio(with features), andmail-parser. (packages/catalog/Cargo.toml)Cargo.tomlfortokioand other libraries, ensuring compatibility and feature support. (Cargo.toml) [1] [2]Documentation and test coverage
Cargo.rstfile documenting all dependencies and providing basic test cases to verify their presence and configuration, especially for workspace dependencies and feature flags. (packages/catalog/Cargo.rst)Code organization and cleanup
apps/desktop/src-tauri/src/functions/app.rsfor improved readability and maintainability. [1] [2] [3] [4]transpilePackagesconfiguration fromapps/desktop/next.config.mjsto simplify the build setup.Sorting logic update
apps/desktop/app/library/page.tsxto usesecs_since_epochinstead ofnanos_since_epochfor created and updated timestamps, improving consistency and possibly performance.Let me know if you have questions about any specific change or want to dive deeper into the new mail functionality!