Feature/113 get custom media working#121
Merged
felix-schultz merged 8 commits intodevfrom Jul 20, 2025
Merged
Conversation
… media item management
…indicators - Improved thumbnail and icon upload handlers to include file type and size validation. - Added loading indicators during upload processes for better user feedback. - Updated UI components for thumbnail and icon uploads to display current images or placeholders. - Refactored code for better readability and maintainability. - Introduced a new BubbleActions component for enhanced action menus in the UI. - Updated relevant imports and exports to include the new BubbleActions component.
- Refactor getBoardSettings to return IConnectionMode instead of string literals. - Enhance StorageState to handle offline scenarios more gracefully and improve error handling. - Introduce media management functions in app.rs for uploading, removing, and transforming media items. - Add support for new media formats and ensure proper URL signing for media uploads. - Update schema definitions to include new fields for app and lookup configurations. - Modify frontend components to utilize new connection modes and improve UI interactions. - Implement image processing utilities for resizing and encoding images to WebP format. - Adjust app search query schema to accommodate new query parameters.
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes across multiple areas, including dependency management, refactoring of image processing logic, and enhancements to the frontend UI for managing application workflows. Below is a summary of the most important changes:
Dependency Management
image,imageproc,webp) toCargo.tomlfor image processing functionality.apps/backend/aws/media-transformer/Cargo.tomlto use workspace versions (image.workspace,imageproc.workspace,webp.workspace, etc.) for better dependency management. [1] [2]Backend Refactoring
is_supported_image_format,resize_image,encode_as_webp) with calls to theflow_like_types::imagesmodule, centralizing image-related logic. [1] [2] [3] [4]Cache-Controlmetadata header to S3 uploads to improve caching behavior for webp images.Frontend Enhancements
Pagecomponent inapps/desktop/app/library/config/flows/page.tsxto modularize UI elements into new components (PageHeader,CreateFlowDialog,StatsOverview,BoardsSection, etc.) for improved readability and maintainability. [1] [2] [3]ContextMenuwithBubbleActionsfor board actions, improving the user interface for managing boards. [1] [2] [3]UI Improvements
apps/desktop/app/library/config/layout.tsxby adding a visibility badge to indicate the app's visibility status. [1] [2]