Fixed misaligned screenshot#217
Merged
pekkakaho merged 4 commits intoFeb 19, 2020
Merged
Conversation
Since getState is called before begineSecquence it should be save to move the logic of setting the system PID and window handle towards getState. This is needed because in getState we create an initial screenshot and therefor we need to have the window handle in order to obtain the display scale.
Fix mouse coordinates for scaled displays Adapt the mouse coordinates to the display scale of the screen
Set Window handle in the access bridge constructor, to solve an issue with swing apps. Use ConcreteIDCustom instead of ConcreteID, because the first one creates a new screenshots if any widget property changes.
pekkakaho
approved these changes
Feb 19, 2020
Member
There was a problem hiding this comment.
Has been tested with:
- Windows display settings 100% + blurry/not blurry and 150% + blurry/not blurry,
- desktop generic and webdriver generic,
- both with master branch and this pull request.
Both master and this pull request have some issues with screenshots with some of the combinations. However, this pull request seems to fix the issues with TESTAR executing actions with wrong coordinates, so it is better than master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed creating screenshots for desktop and webdriver on windows.
NOTE: Webdriver is currently only fixed for chrome browser