Altered SCons build scripts to work with Python 3.#75
Merged
Conversation
Contributor
|
backwards compatibility is not very important. there are many reasons to still prefer python2 over python3 as a developer, but there's no reason not to tell people they must install python3. |
|
Hi. Could we get a new release with this change? I looks like this patch does not properly apply on the latest release. I am from the Homebrew package manager team and we got rid of Python 2. We would like to make sure we can continue to ship fceux in the future. Thanks! |
5 tasks
Contributor
|
This is not a complicated patch. Maybe you need to apply all the patches which affect SConstruct, not just this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't added the following to the top of these scripts:
I believe this would allow Python 2 to run these scripts (I'm not certain and I haven't tested). Is backwards compatibility wanted moving forward?